fix: use r.Selected instead of r.Reachable for NTP selected label - #384
Open
Aprazor wants to merge 1 commit into
Open
fix: use r.Selected instead of r.Reachable for NTP selected label#384Aprazor wants to merge 1 commit into
Aprazor wants to merge 1 commit into
Conversation
All 7 MustNewConstMetric calls passed r.Reachable for both the reachable and selected label positions. The selected label always showed the reachable value, making it meaningless. Signed-off-by: Aprazors <Aprazors@gmail.com>
Aprazor
force-pushed
the
fix/ntp-selected-label-copy-paste
branch
from
March 21, 2026 04:54
80aa6cb to
076b291
Compare
Contributor
|
sorry for reviewing late, the fix looks good to me, but the tests also need updates now - can change them as well so we can get this one merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 7 MustNewConstMetric calls passed r.Reachable for both the
reachable and selected label positions. The selected label always
showed the reachable value, making it meaningless.